[webkit-reviews] review denied: [Bug 89693] Web Inspector: timeline instrumentation for screen update : [Attachment 148894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 20:21:41 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 89693: Web Inspector: timeline instrumentation for screen update
https://bugs.webkit.org/show_bug.cgi?id=89693

Attachment 148894: Patch
https://bugs.webkit.org/attachment.cgi?id=148894&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148894&action=review


> Source/WebCore/ChangeLog:8
> +	   Added TimelineRecordType::UpdateScreen and plumbed it all the way
through to InspectorInstrumentation.

What does UpdateScreen mean?

> Source/WebCore/inspector/front-end/TimelineModel.js:54
> +    UpdateScreen: "UpdateScreen",

Make sure you fix the test for this?


More information about the webkit-reviews mailing list