[webkit-reviews] review granted: [Bug 89632] DFG should inline 'new Array()' : [Attachment 148900] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 21 15:30:19 PDT 2012
Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 89632: DFG should inline 'new Array()'
https://bugs.webkit.org/show_bug.cgi?id=89632
Attachment 148900: the patch
https://bugs.webkit.org/attachment.cgi?id=148900&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148900&action=review
r=me
> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1618
> + if (kind != CodeForConstruct)
> + return false;
Actually, 'new Array()' and 'Array()' are equivalent. So, you should remove
this check for great good.
More information about the webkit-reviews
mailing list