[webkit-reviews] review denied: [Bug 88268] [chromium] Expose rendering statistics to WebLayerTreeView. : [Attachment 148706] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dave Tu <dtu at chromium.org>'s request
for review:
Bug 88268: [chromium] Expose rendering statistics to WebLayerTreeView.
https://bugs.webkit.org/show_bug.cgi?id=88268

Attachment 148706: Patch
https://bugs.webkit.org/attachment.cgi?id=148706&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148706&action=review


> Source/Platform/chromium/public/WebRenderingStats.h:56
> +    WebSerializedScriptValue value()
> +    {
> +	   v8::Handle<v8::Object> stats = v8::Object::New();
> +	   if (numAnimationFrames)
> +	       stats->Set(v8::String::New("numAnimationFrames"),
> +				 v8::Integer::New(numAnimationFrames),
> +				 v8::ReadOnly);
> +	   if (numFramesSentToScreen)
> +	       stats->Set(v8::String::New("numFramesSentToScreen"),
> +				 v8::Integer::New(numFramesSentToScreen),
> +				 v8::ReadOnly);
> +	   return WebSerializedScriptValue::serialize(stats);
> +    }

I don't undertand why this function is here.  This doesn't look right.