[webkit-reviews] review granted: [Bug 89081] [Shadow] Assertion in VisibleSelection::adjuseSelectionToAvoidCrossingBoundaries() is triggered : [Attachment 148895] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 89081: [Shadow] Assertion in
VisibleSelection::adjuseSelectionToAvoidCrossingBoundaries() is triggered
https://bugs.webkit.org/show_bug.cgi?id=89081

Attachment 148895: Patch
https://bugs.webkit.org/attachment.cgi?id=148895&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148895&action=review


> Source/WebCore/editing/htmlediting.cpp:267
> +

Why the blank line? I'd rather have blank lines in both functions or not have
in either one.
Doing different things in firstEditablePositionAfterPositionInRoot and
lastEditablePositionBeforePositionInRoot is confusing.

>
LayoutTests/editing/shadow/adjusting-editing-boundary-with-table-in-shadow-expe
cted.txt:1
> +PASS

It's odd to see PASS before the description.

>
LayoutTests/editing/shadow/adjusting-editing-boundary-with-table-in-shadow.html
:15
> +<p>Placing this sentence before table won't trigger an asertion.</p>
> +<p>Selecting around a table which is distributed from shadow subtree to
nested shadow subtree will trigger an assertion. To try manually, select from
"shadow 2" to around "after" and confirm a crash does not occur.</p>

Please place this description before the container.