[webkit-reviews] review granted: [Bug 89685] [Qt] Allow DumpRenderTree to dump about:blank : [Attachment 148864] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 14:41:25 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 89685: [Qt] Allow DumpRenderTree to dump about:blank
https://bugs.webkit.org/show_bug.cgi?id=89685

Attachment 148864: proposed patch
https://bugs.webkit.org/attachment.cgi?id=148864&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148864&action=review


> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:704
> +	       || line == QLatin1String("about:blank")) {

Should we allow all "about:"?


More information about the webkit-reviews mailing list