[webkit-reviews] review requested: [Bug 88741] Width not properly recalculated with -webkit-box-sizing: border-box : [Attachment 148879] Proposed patch

[bugzilla-daemon at webkit.org]

Kulanthaivel Palanichamy <kulanthaivel at codeaurora.org> has asked  for review:
Bug 88741: Width not properly recalculated with -webkit-box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=88741

Attachment 148879: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=148879&action=review

------- Additional Comments from Kulanthaivel Palanichamy
<kulanthaivel at codeaurora.org>
Ideally we should have been able to detect content box size change in
RenderBlock::recomputeLogicalWidth(), but 
unfortunately we never keep the old style in RenderObject to compare old border
and padding values.
One another possible fix could be compare the old and new styles in
RenderBox::styleDidChange() for
border and padding change when box-sizing is border-box, set
setChildNeedsLayout(true),
then force relayout on children in RenderBlock::layoutBlockChildren() if
normalChildNeedsLayout() is true.