[webkit-reviews] review denied: [Bug 89244] Web Inspector: Add data length to resource events on timeline to keep track of the amount of data loaded and the total data length : [Attachment 148872] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Hanna <hanma at rim.com>'s request for
review:
Bug 89244: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length
https://bugs.webkit.org/show_bug.cgi?id=89244

Attachment 148872: Patch
https://bugs.webkit.org/attachment.cgi?id=148872&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148872&action=review


Looks good, some small stuff to fix still.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:415
> +	   if (record.type === recordTypes.ResourceFinish)

Could add else here.

> LayoutTests/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

Reviewed by should be first, then empty line, then description.

> LayoutTests/inspector/timeline/timeline-network-received-data.html:38
> +	       if (record.type ===
WebInspector.TimelineModel.RecordType.ResourceReceivedData){

Add space between ')' and '{'.

> LayoutTests/inspector/timeline/timeline-network-received-data.html:40
> +}

Please indent properly.