[webkit-reviews] review requested: [Bug 89681] [chromium] Allow impl thread to delete all allocated textures in TextureManager : [Attachment 148853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 12:00:04 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 89681: [chromium] Allow impl thread to delete all allocated textures in
TextureManager
https://bugs.webkit.org/show_bug.cgi?id=89681

Attachment 148853: Patch
https://bugs.webkit.org/attachment.cgi?id=148853&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
I think the visiblity stuff makes the previous code ok but it isn't obvious
that it's threadsafe. I looked at your patch again James to see how you're
calling the TextureAllocator and TextureManager and mimicing that a bit better.
So the Proxy can decide to tell the TM that everything is deleted or not as you
currently do. This just lets us do the texture id tracking/free here instead of
adding it to TextureAllocator, which was the intention.


More information about the webkit-reviews mailing list