[webkit-reviews] review requested: [Bug 89678] Web Inspector: Support 'Restart frame' in inspector frontend : [Attachment 148840] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 11:24:03 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has asked  for review:
Bug 89678: Web Inspector: Support 'Restart frame' in inspector frontend
https://bugs.webkit.org/show_bug.cgi?id=89678

Attachment 148840: Patch
https://bugs.webkit.org/attachment.cgi?id=148840&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148840&action=review


> Source/WebCore/inspector/front-end/CallStackSidebarPane.js:192
> +	   this._pane.contributeToContextMenu(contextMenu);

I would keep context menu population in one method of CallStackSidebarPane.
E.g. in eclipse "restart frame" is in the middle of context menu which would be
hard to implement with current approach.


More information about the webkit-reviews mailing list