[webkit-reviews] review requested: [Bug 89660] [GTK] Add support for graphviz debug output for the gstreamer video pipeline : [Attachment 148844] Patch for supporting graphviz debug output

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 11:05:46 PDT 2012


Allan Xavier <allan.xavier at undefinedltd.co.uk> has asked  for review:
Bug 89660: [GTK] Add support for graphviz debug output for the gstreamer video
pipeline
https://bugs.webkit.org/show_bug.cgi?id=89660

Attachment 148844: Patch for supporting graphviz debug output
https://bugs.webkit.org/attachment.cgi?id=148844&action=review

------- Additional Comments from Allan Xavier <allan.xavier at undefinedltd.co.uk>
This revised patch has the following changes:

* The improvements recommended by Martin in comment #3.
* The string formatting call is now split onto multiple lines for better
readability.
* The pendingState variable has been removed (gst_message_parse_state_changed
can handle null arguments).


More information about the webkit-reviews mailing list