[webkit-reviews] review granted: [Bug 89673] showModalDialog fix creates risk of never returning from RunLoop::performWork, potentially blocking other event sources : [Attachment 148837] Patch v2 - Avoid taking the lock twice for the common case *and* avoid the branch comparison in Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 89673: showModalDialog fix creates risk of never returning from
RunLoop::performWork, potentially blocking other event sources
https://bugs.webkit.org/show_bug.cgi?id=89673

Attachment 148837: Patch v2 - Avoid taking the lock twice for the common case
*and* avoid the branch comparison in Patch v1
https://bugs.webkit.org/attachment.cgi?id=148837&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148837&action=review


I know Anders will review too. Looks fine to me, thought.

> Source/WebCore/platform/RunLoop.cpp:72
> +    // we guarantee that we will occassionally return from the run loop and
other event sources will have

Typo: occasionally has only one s