[webkit-reviews] review granted: [Bug 60732] Add support for the grid and inline-grid display types. : [Attachment 148714] Grumble, grumble. ENABLE_CSS_GRID_LAYOUT is dead...

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 60732: Add support for the grid and inline-grid display types.
https://bugs.webkit.org/show_bug.cgi?id=60732

Attachment 148714: Grumble, grumble. ENABLE_CSS_GRID_LAYOUT is dead...
https://bugs.webkit.org/attachment.cgi?id=148714&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148714&action=review


Please make sure the Qt ews bots are green before landing.

> Source/WebCore/ChangeLog:21
> +	   * CMakeLists.txt:
> +	   * GNUmakefile.list.am:
> +	   * WebCore.gypi:
> +	   * WebCore.vcproj/WebCore.vcproj:
> +	   * WebCore.xcodeproj/project.pbxproj:

Qt failure is because Target.pri is missing.

> Source/WebCore/rendering/RenderObject.cpp:157
>      case GRID:
>      case INLINE_GRID:
> +	   return new (arena) RenderGrid(node);

Nit: I would move this below FLEX and INLINE_FLEX to match the order of the
enum.