[webkit-reviews] review denied: [Bug 89646] Web Inspector: Support separate script compilation and execution. : [Attachment 148805] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 89646: Web Inspector: Support separate script compilation and execution.
https://bugs.webkit.org/show_bug.cgi?id=89646

Attachment 148805: Patch
https://bugs.webkit.org/attachment.cgi?id=148805&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148805&action=review


> Source/WebCore/inspector/Inspector.json:2557
> +		       { "name": "objectGroup", "type": "string", "optional":
true, "description": "Symbolic group name that can be used to release multiple
objects." },

You don't need objectGroup when compiling.

> Source/WebCore/inspector/Inspector.json:2562
> +		       { "name": "exception", "$ref": "Runtime.RemoteObject",
"optional": true, "description": "Object wrapper for compilation exception if
there was one." }

This should be returned as a protocol error string instead.

> Source/WebCore/inspector/Inspector.json:2564
> +		   "description": "Compiles expression in a given context."

There is no context.

> Source/WebCore/inspector/Inspector.json:2571
> +		       { "name": "scriptId", "$ref": "ScriptId", "description":
"Id of the script to run." },

open topic, nit: I wonder if script ids should be actually shared between
debugger and this. What if user runs existing script again?