[webkit-reviews] review denied: [Bug 40300] [JSC] Web Inspector: implement script source editing : [Attachment 148778] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 40300: [JSC] Web Inspector: implement script source editing
https://bugs.webkit.org/show_bug.cgi?id=40300

Attachment 148778: Patch
https://bugs.webkit.org/attachment.cgi?id=148778&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148778&action=review


> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:85
> +{

You should change the script with given sourceID live, you are evaluating
newContent here, basically creating a new script instead of changing the old
one.