[webkit-reviews] review denied: [Bug 88207] [EFL][WK2] Make WebKit2/Efl headers and resources installable. : [Attachment 147015] Patch

[bugzilla-daemon at webkit.org]

Chang Shu <cshu at webkit.org> has denied Ryuan Choi <ryuan.choi at samsung.com>'s
request for review:
Bug 88207: [EFL][WK2] Make WebKit2/Efl headers and resources installable.
https://bugs.webkit.org/show_bug.cgi?id=88207

Attachment 147015: Patch
https://bugs.webkit.org/attachment.cgi?id=147015&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review


> Source/WebKit2/CMakeLists.txt:546
> +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin)

I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a
hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined?
Please take a loot at bug 71507.