[webkit-reviews] review granted: [Bug 87856] Web Inspector: Add getMetadata command and gotMetadata event to FileSystem : [Attachment 148726] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 87856: Web Inspector: Add getMetadata command and gotMetadata event to
FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856

Attachment 148726: Patch
https://bugs.webkit.org/attachment.cgi?id=148726&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148726&action=review


> Source/WebCore/inspector/Inspector.json:1497
> +		       { "name": "requestId", "type": "integer", "description":
"Request Identifier that was passed to corresponding getMetadata request." },

Request Identifier that was returned in response to the corresponding
getMetadata request.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:461
> +    if (!m_enabled || !m_frontendProvider)

Report an error in the ErrorString?

> Source/WebCore/inspector/front-end/FileSystemModel.js:460
> +		   store[requestId] = callback;

not: you can pass requestAccepted.bind(this) as FileSystemAgent.requestMetadata
parameter above and call this._pendingMetadataRequests[requestId] = callback;
here. This is how we usually deal with bound callbacks in the front-end code.

> LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:120
> +	       if (writer.readyState == writer.DONE)

== -> ===