[webkit-reviews] review granted: [Bug 89592] Web Inspector: [WebGL] Add injected WebGL module class : [Attachment 148727] Rebased patch to land

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 89592: Web Inspector: [WebGL] Add injected WebGL module class
https://bugs.webkit.org/show_bug.cgi?id=89592

Attachment 148727: Rebased patch to land
https://bugs.webkit.org/attachment.cgi?id=148727&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148727&action=review


> Source/WebCore/inspector/InjectedScriptWebGLModule.h:49
> +    static InjectedScriptWebGLModule
injectedModuleForState(InjectedScriptManager*, ScriptState*);

ensureModuleInjectedForState or simply moduleForState?

> Source/WebCore/inspector/InspectorWebGLAgent.cpp:100
> +    ASSERT(!glContext.hasNoValue());

Put ASSERT_NOT_REACHED() in the if block below instead.

> Source/WebCore/inspector/InspectorWebGLAgent.cpp:105
> +    if (module.hasNoValue())

Put ASSERT_NOT_REACHED() in the if block below instead.