[webkit-reviews] review granted: [Bug 89621] SVGImageCache isn't invalidated for <img> on dynamic page scale changes : [Attachment 148730] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 89621: SVGImageCache isn't invalidated for <img> on dynamic page scale
changes
https://bugs.webkit.org/show_bug.cgi?id=89621

Attachment 148730: patch
https://bugs.webkit.org/attachment.cgi?id=148730&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148730&action=review


>
LayoutTests/platform/mac/svg/as-image/image-respects-pageScaleFactor-change-exp
ected.txt:17
> +layer at (0,0) size 785x585
> +  RenderView at (0,0) size 785x585
> +layer at (0,0) size 785x585
> +  RenderBlock {HTML} at (0,0) size 785x585
> +    RenderBody {BODY} at (8,8) size 769x561
> +	 RenderBlock (anonymous) at (0,0) size 769x132
> +	   RenderImage {IMG} at (0,96) size 32x32
> +	   RenderText {#text} at (32,114) size 4x18
> +	     text run at (32,114) width 4: " "
> +	   RenderImage {IMG} at (36,0) size 128x128
> +	   RenderText {#text} at (0,0) size 0x0
> +	 RenderBlock {P} at (0,148) size 769x18
> +	   RenderText {#text} at (0,0) size 342x18
> +	     text run at (0,0) width 342: "This test passes if both of the
circles have sharp edges."
> +	 RenderBlock {P} at (0,182) size 769x18
> +	   RenderText {#text} at (0,0) size 440x18
> +	     text run at (0,0) width 440: "To run manually, use full-page zoom
to increase the page scale factor."

Is this useful? Maybe dumpAsText(true).

> Source/WebCore/svg/graphics/SVGImageCache.cpp:148
> +	   scale = renderer->document()->page()->deviceScaleFactor() *
renderer->document()->page()->pageScaleFactor();

Might as well fetch renderer->document()->page() just once.