[webkit-reviews] review denied: [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs : [Attachment 148697] Patch with a proposed fix for the bug (with layout tests, more recently synced, no extra files, better style)

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Pete Williamson
<petewil at chromium.org>'s request for review:
Bug 88665: Favicon URL list sent with favicon updated message contains out of
date icon URLs
https://bugs.webkit.org/show_bug.cgi?id=88665

Attachment 148697: Patch with a proposed fix for the bug (with layout tests,
more recently synced, no extra files, better style)
https://bugs.webkit.org/attachment.cgi?id=148697&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148697&action=review


The code is over-commented. We can get rid of most of them.

On linker errors, you need to export some symbols which is referred from the
Internals object.
See http://trac.webkit.org/changeset/120684 as an example.
WebCore.exp.in, WebKit2.def, symbols.fitter are such files.

> Source/WebCore/dom/Document.cpp:4877
> +    // Ensure URL is not already in the list before adding it.

This comment can be removed.

> Source/WebCore/testing/Internals.h:185
> +    PassRefPtr<DOMStringList> dumpIconURLs(Document*) const;

"dump" is redundant.

> Source/WebKit/chromium/public/WebFrame.h:-148
> -    virtual WebVector<WebIconURL> iconURLs(int iconTypes) const = 0;

I don't think we need to change this const-ness.