[webkit-reviews] review canceled: [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs : [Attachment 148601] Patch with a proposed fix for the bug (with layout tests, more recently synced, no extra files, better style)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 18:13:19 PDT 2012


Pete Williamson <petewil at chromium.org> has canceled Pete Williamson
<petewil at chromium.org>'s request for review:
Bug 88665: Favicon URL list sent with favicon updated message contains out of
date icon URLs
https://bugs.webkit.org/show_bug.cgi?id=88665

Attachment 148601: Patch with a proposed fix for the bug (with layout tests,
more recently synced, no extra files, better style)
https://bugs.webkit.org/attachment.cgi?id=148601&action=review

------- Additional Comments from Pete Williamson <petewil at chromium.org>
Slight changes to approach based on CR feedback.  
We now always calculate the URL list.
We changed the way we build the list of IconURLs to be a bit simpler(using the
existing KURL instead of making a new one, less string manipulation)
We now use a list of URLs in the Internals method instead of a big concatenated
string.


More information about the webkit-reviews mailing list