[webkit-reviews] review granted: [Bug 89609] IndexedDB: Fix layout tests to clear previous database structures : [Attachment 148671] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 16:11:35 PDT 2012


Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 89609: IndexedDB: Fix layout tests to clear previous database structures
https://bugs.webkit.org/show_bug.cgi?id=89609

Attachment 148671: Patch
https://bugs.webkit.org/attachment.cgi?id=148671&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148671&action=review


> LayoutTests/ChangeLog:10
> +	   A handful of tests weren't deleting previously created stores (or
the whole
> +	   database), which made them fail if trivially re-run in Chromium or
under
> +	   NRWT with --iterations=2.

Should DRT delete all databases between tests?	See
TestShell::resetTestController() where we reset other things
Tools/DumpRenderTree/chromium/TestShell.cpp.


More information about the webkit-reviews mailing list