[webkit-reviews] review granted: [Bug 89215] master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep : [Attachment 147822] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 89215: master.cfg cleanup: Pass CheckOutSource instance instead of class to
BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215

Attachment 147822: Patch
https://bugs.webkit.org/attachment.cgi?id=147822&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147822&action=review


> Tools/ChangeLog:6
> +
> +	   Reviewed by NOBODY (OOPS!).

Nit: Can you include the 'why' (what you wrote in comment #0) in the changelog?


> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:117
> +    def __init__(self, **kwargs):

Nit: Do we need **kwargs here? I only see one caller for CheckOutSource and it
doesn't pass any flags.