[webkit-reviews] review granted: [Bug 89555] Web Inspector: Move requestId allocation from FileSystem frontend to backend : [Attachment 148527] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 89555: Web Inspector: Move requestId allocation from FileSystem frontend to
backend
https://bugs.webkit.org/show_bug.cgi?id=89555

Attachment 148527: Patch
https://bugs.webkit.org/attachment.cgi?id=148527&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148527&action=review


Please fix a couple of nits before landing.

> Source/WebCore/ChangeLog:10
> +

Please remove extra blank line.

> Source/WebCore/inspector/Inspector.json:1441
> +		       { "name": "requestId", "$ref": "FileSystem.RequestId",
"description": "Request identifier. Corresponding fileSystemRootReceived event
should have same requestId with this." }

"$ref": "RequestId" is enough since you are inside FileSystem domain.

> Source/WebCore/inspector/Inspector.json:1453
> +		   "description": "Returns content of the directory as
didReadDirectory event."

didReadDirectory ->directoryContentReceived

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:413
> +    ASSERT(requestId);

This is up to the protocol implementation to provide correct output parameter
pointer, you should not check it here.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:427
> +    ASSERT(requestId);

Ditto.