[webkit-reviews] review granted: [Bug 89515] REGRESSION(r113885): Margin not properly applied to elements with align=center : [Attachment 148618] Proposed change v1: patch computeInlineDirectionMargins.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 20 13:57:22 PDT 2012
Levi Weintraub <leviw at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 89515: REGRESSION(r113885): Margin not properly applied to elements with
align=center
https://bugs.webkit.org/show_bug.cgi?id=89515
Attachment 148618: Proposed change v1: patch computeInlineDirectionMargins.
https://bugs.webkit.org/attachment.cgi?id=148618&action=review
------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148618&action=review
>> Source/WebCore/rendering/RenderBox.cpp:1840
>> + containingBlock->setMarginEndForChild(this, containerWidth -
childWidth - containingBlock->marginStartForChild(this) + marginEndWidth);
>
> Seems like the right fix to me!
Sounds good!
More information about the webkit-reviews
mailing list