[webkit-reviews] review granted: [Bug 89595] [BlackBerry] Input mode should adapt automatically to settings changes : [Attachment 148648] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 13:51:34 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has granted Mike Fenton
<mifenton at rim.com>'s request for review:
Bug 89595: [BlackBerry] Input mode should adapt automatically to settings
changes
https://bugs.webkit.org/show_bug.cgi?id=89595

Attachment 148648: Patch
https://bugs.webkit.org/attachment.cgi?id=148648&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148648&action=review


I think I like the name isInputMethodEnabled more. Up to you...

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:435
> +bool InputHandler::inputModeEnabled()

const?


More information about the webkit-reviews mailing list