[webkit-reviews] review granted: [Bug 89437] [GTK] Read fonts path in DRT from WEBKIT_TEST_FONTS_PATH env var if present : [Attachment 148267] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 89437: [GTK] Read fonts path in DRT from WEBKIT_TEST_FONTS_PATH env var if
present
https://bugs.webkit.org/show_bug.cgi?id=89437

Attachment 148267: Patch
https://bugs.webkit.org/attachment.cgi?id=148267&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148267&action=review


Looks good. Can you please also update the relevant wiki page? Thanks!

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:68
> +	   if os.environ.get('WEBKIT_TEST_FONTS_PATH'):
> +	       environment['WEBKIT_TEST_FONTS_PATH'] =
os.environ['WEBKIT_TEST_FONTS_PATH']

This can be one line
environment['WEBKIT_TEST_FONTS_PATH'] =
os.environ.get('WEBKIT_TEST_FONTS_PATH','')