[webkit-reviews] review requested: [Bug 86275] [Chromium] Support for direct GPU texture copy between Canvas2D and WebGL Textures : [Attachment 148637] Patch

[bugzilla-daemon at webkit.org]

Jeff Timanus <twiz at chromium.org> has asked  for review:
Bug 86275: [Chromium] Support for direct GPU texture copy between Canvas2D and
WebGL Textures
https://bugs.webkit.org/show_bug.cgi?id=86275

Attachment 148637: Patch
https://bugs.webkit.org/attachment.cgi?id=148637&action=review

------- Additional Comments from Jeff Timanus <twiz at chromium.org>
This should be close to the last revision of this change.  The copy is now
performed by the ImageBuffer class, which accesses the backing store texture of
the canvas via the Canvas2DLayerBridge.

Points of note:
 - I added the plumbing for the flipy and pre-multiplied-alpha GL command
buffer extensions.  Note that the WebGLRenderingContext does NOT forward these
settings to the graphics context.  The flipy and premultiply alpha settings
cached on the WebGLRenderingContext instance are used just as they were
previously:  When performing texture uploads via the software read-back path. 
The settings are used on the GraphicsContext side only when invoking
ImageBuffer::copyToPlatformTexture.
 - The mips issue is still present in this version of the patch.  The problem
is not related to this change, and can reproduced in WebGL.  See tracking
issue:	crbug.com/132641
 - The fast gpu path causes a text difference in
fast/canvas/webgl/gltex-image/.  See tracking bug for new rebaseline: 
wkbug.com/89494