[webkit-reviews] review granted: [Bug 87495] [WK2] Color chooser API missing : [Attachment 147546] Patch v5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 20 13:02:27 PDT 2012
Andreas Kling <kling at webkit.org> has granted Thiago Marcos P. Santos
<tmpsantos at gmail.com>'s request for review:
Bug 87495: [WK2] Color chooser API missing
https://bugs.webkit.org/show_bug.cgi?id=87495
Attachment 147546: Patch v5
https://bugs.webkit.org/attachment.cgi?id=147546&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147546&action=review
r=me based on Anders's prior assessment and the patch looking generally fine to
me.
> Source/WebKit2/WebProcess/WebCoreSupport/WebColorChooser.h:45
> + ~WebColorChooser();
Should mark this explicitly virtual.
More information about the webkit-reviews
mailing list