[webkit-reviews] review denied: [Bug 89421] [CSSRegions]Change WEBKIT_REGION_RULE value to 16 : [Attachment 148567] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 11:33:28 PDT 2012


Tony Chang <tony at chromium.org> has denied Andrei Onea <onea at adobe.com>'s
request for review:
Bug 89421: [CSSRegions]Change WEBKIT_REGION_RULE value to 16
https://bugs.webkit.org/show_bug.cgi?id=89421

Attachment 148567: patch
https://bugs.webkit.org/attachment.cgi?id=148567&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148567&action=review


> Source/WebCore/css/CSSRule.cpp:49
> +COMPILE_ASSERT(StyleRuleBase::Region ==
static_cast<StyleRuleBase::Type>(CSSRule::WEBKIT_REGION_RULE),
enums_should_match);

Looks like this needs to be in an #if ENABLE(CSS_REGIONS) block.


More information about the webkit-reviews mailing list