[webkit-reviews] review granted: [Bug 88228] [CSS3 Backgrounds and Borders] Implement box-decoration-break rendering. : [Attachment 147287] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 88228: [CSS3 Backgrounds and Borders] Implement box-decoration-break
rendering.
https://bugs.webkit.org/show_bug.cgi?id=88228

Attachment 147287: Patch
https://bugs.webkit.org/attachment.cgi?id=147287&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147287&action=review


Looks totally fine to me.

> Source/WebCore/rendering/InlineFlowBox.cpp:1119
> +	   paintInfo.context->clip(LayoutRect(rect.x(), rect.y(), width(),
height()));

Sad you have to create your own LayoutRect like this.  SUrprised there isn't a
helper.