[webkit-reviews] review denied: [Bug 89562] Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high CPU usage : [Attachment 148583] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 89562: Regression(r116408): Ctrl-A (select all) on large text file hangs
the tab with high CPU usage
https://bugs.webkit.org/show_bug.cgi?id=89562

Attachment 148583: Patch
https://bugs.webkit.org/attachment.cgi?id=148583&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148583&action=review


> Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp:65
> +	   ++index;
>      }

Nit: I would just make this a for loop.

> Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp:66
> +    str.swap(result.toString());

Looks like this doesn't compile, I bet you can't swap without holding a
reference. I'll try and upload a fix.