[webkit-reviews] review granted: [Bug 89551] DFG should be able to print disassembly interleaved with the IR : [Attachment 148519] improved patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 89551: DFG should be able to print disassembly interleaved with the IR
https://bugs.webkit.org/show_bug.cgi?id=89551

Attachment 148519: improved patch
https://bugs.webkit.org/attachment.cgi?id=148519&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148519&action=review


r=me, but please double-check dominators removal, and add a comment to the
ChangeLog explaining why.

> Source/JavaScriptCore/dfg/DFGDriver.cpp:-95
> -    dfg.m_dominators.compute(dfg);

Was this on purpose? Seems wrong.