[webkit-reviews] review requested: [Bug 86882] [chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2 : [Attachment 148571] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 08:12:09 PDT 2012


vollick at chromium.org has asked	for review:
Bug 86882: [chromium] Make sure that render surfaces are not pixel doubled with
a device scale factor of 2
https://bugs.webkit.org/show_bug.cgi?id=86882

Attachment 148571: Patch
https://bugs.webkit.org/attachment.cgi?id=148571&action=review

------- Additional Comments from vollick at chromium.org
Sadly, it looks like we need to go one more round (thanks for your patience
with
this). As Dana was mentioning, bounds aren't quite in css pixels. They do have
page zoom baked in (but not page scale), so they're logical pixels. I've
confirmed this -- as I change the page scale, the viewport's bounds are the
same
but, the bounds of a layer or render surface do vary. I've updated the comments
in LayerChromium and replaced instances of 'css pixels' with 'logical,
non-page-scaled pixels'. There's also a more detailed explanation of the term
where I first use it.


More information about the webkit-reviews mailing list