[webkit-reviews] review denied: [Bug 89559] Web Inspector: handling enter key bug : [Attachment 148546] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 89559: Web Inspector: handling enter key bug
https://bugs.webkit.org/show_bug.cgi?id=89559

Attachment 148546: Patch
https://bugs.webkit.org/attachment.cgi?id=148546&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148546&action=review


> Source/WebCore/ChangeLog:3
> +	   Fixing Bug 89559 - Web Inspector: handling enter key bug

Patch should start with the bug title.

> Source/WebCore/ChangeLog:5
> +	   Web Inspector: handling enter key bug

This bug title is too vague, please be more specific

> Source/WebCore/ChangeLog:12
> +	   The person who fixed Bug 71625 forgot to use result of his own
method.

We typically say "Regressed in rXXXX" where XXXX is a revision number. That
should be mentioned in the bug description.

> Source/WebCore/inspector/front-end/TextViewer.js:1254
>	   this._exitTextChangeMode(range, newRange);

You should call exitTextChangeMode with exact newRange that editRange returned.