[webkit-reviews] review denied: [Bug 89567] Web Inspector: don't report context ids before DidCommitLoad : [Attachment 148554] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 89567: Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567

Attachment 148554: Patch
https://bugs.webkit.org/attachment.cgi?id=148554&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148554&action=review


> Source/WebCore/inspector/PageRuntimeAgent.cpp:89
> +    if (m_inspectorAgent->didCommitLoadFired()) {

I would instead delegate original didCommitLoad instrumentation here and stored
the state (i.e. copied the inspectorAgent's logic).