[webkit-reviews] review denied: [Bug 40300] [JSC] Web Inspector: implement script source editing : [Attachment 148524] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 40300: [JSC] Web Inspector: implement script source editing
https://bugs.webkit.org/show_bug.cgi?id=40300

Attachment 148524: Patch
https://bugs.webkit.org/attachment.cgi?id=148524&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148524&action=review


> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:91
> +    const ScriptValue& value = frame->script()->executeScript(newContent);

This will just re-evaluate the script as if you were running it in the
inspector console while setScriptSource command should allow you to modify a
function that may have already been run and leave other stuff untouched if its
source doesn't change. E.g. changing 

"var count = 1;
function foo()
{
    count++;
}"

to

"var count = 1;
function foo()
{
    count--;
}"

shouldn't reset value of the count variable to 1.