[webkit-reviews] review requested: [Bug 89551] DFG should be able to print disassembly interleaved with the IR : [Attachment 148519] improved patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 20 00:29:56 PDT 2012
Filip Pizlo <fpizlo at apple.com> has asked for review:
Bug 89551: DFG should be able to print disassembly interleaved with the IR
https://bugs.webkit.org/show_bug.cgi?id=89551
Attachment 148519: improved patch
https://bugs.webkit.org/attachment.cgi?id=148519&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Fixed style issues.
Also fixed a small issue in dumping of code that was not generated. The
previous patch would dump neither the IR nor the disassembly for such nodes.
The current patch will dump the IR but not the disassembly, and will make sure
that the disassembly for the previous node is dumped correctly. To be clear,
what I mean by "code that was not generated" is either code that was after a
forced OSR exit (the IR for such code is relevant from the standpoint of
liveness) or Branches that were not really emitted due to peephole
optimizations.
More information about the webkit-reviews
mailing list