[webkit-reviews] review granted: [Bug 89530] Web Inspector: Allow module injections into the InjectedScript : [Attachment 148491] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 89530: Web Inspector: Allow module injections into the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89530

Attachment 148491: Patch
https://bugs.webkit.org/attachment.cgi?id=148491&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148491&action=review


> Source/WebCore/inspector/InjectedScriptBase.h:53
> +    virtual String name() const = 0;

Just pass it as a constructor parameter?

> Source/WebCore/inspector/InjectedScriptBase.h:70
> +    friend class InjectedScriptModule;

I'd rather introduce protected method initialize(ScriptObject,
inspectedStateAccessCheck)

> Source/WebCore/inspector/InjectedScriptModule.cpp:51
> +    ASSERT(!injectedScript.hasNoValue());

If InjectedScript is required we may have injectModule method defined on
InjectedScript and avoid this check and InjectedScriptManager parameter.