[webkit-reviews] review granted: [Bug 88458] [GTK] Combine WebKit API tests into fewer binaries : [Attachment 147911] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 88458: [GTK] Combine WebKit API tests into fewer binaries
https://bugs.webkit.org/show_bug.cgi?id=88458

Attachment 147911: Patch
https://bugs.webkit.org/attachment.cgi?id=147911&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147911&action=review


Looks good to me, please fix the a11y skipped test before landing.

> Tools/gtk/run-api-tests:160
> +	      
self._skipped_tests.append(SkippedTest(WebKit2APITests/TestWebKitAccessibility,
SkippedTest.ENTIRE_SUITE, "Could not start accessibility bus", 0))

I think this line is longer than 120, it would be easier to read if it's split,
I think. What is the last 0? the bug number? You don't need to give that
parameter as it takes None by default and we explicitly check for None. Does it
even work? the test name is missing quotation marks