[webkit-reviews] review canceled: [Bug 89061] applyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable. : [Attachment 148489] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 19 23:18:43 PDT 2012
Takashi Sakamoto <tasak at google.com> has canceled review:
Bug 89061: applyAuthorStyles makes rules declared in all enclosing shadow dom
subtrees applicable.
https://bugs.webkit.org/show_bug.cgi?id=89061
Attachment 148489: Patch
https://bugs.webkit.org/attachment.cgi?id=148489&action=review
------- Additional Comments from Takashi Sakamoto <tasak at google.com>
I'm sorry. I found one mistake. I have to use setupScopeStack(m_parentNode) in
matchScopedAuthorRules. The current patch doesn't satisfy the spec:
- the styles of the insertion point node are inherited by those child nodes of
the shadow host that are assigned to this insertion point
(http://www.w3.org/TR/shadow-dom/#styles)
I will fix soon.
Best regards,
Takashi Sakamoto
More information about the webkit-reviews
mailing list