[webkit-reviews] review requested: [Bug 86882] [chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2 : [Attachment 148495] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 86882: [chromium] Make sure that render surfaces are not pixel doubled with
a device scale factor of 2
https://bugs.webkit.org/show_bug.cgi?id=86882

Attachment 148495: Patch
https://bugs.webkit.org/attachment.cgi?id=148495&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #35)
> (From update of attachment 148484 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=148484&action=review
>
> What about my previous comment #32, re:
surfaceOriginToReplicaOriginTransform?
Sorry, I missed this. You're completely right, there was a scale missing. This
should be fixed in the current patch. Confirmed with
--show-composited-layer-borders
and checked in the unit test.
>
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:794
> > +		 FloatPoint3D layerSpaceSurfaceCenter = surfaceCenter * (1 /
contentsScale);
>
> FloatPoint3D => FloatPoint?
Done.