[webkit-reviews] review denied: [Bug 89545] [Chromium] Missing setCookieEnabled accessor in WebView : [Attachment 148492] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 20:35:50 PDT 2012


Adam Barth <abarth at webkit.org> has denied Garret Kelly (Google)
<gdk at chromium.org>'s request for review:
Bug 89545: [Chromium] Missing setCookieEnabled accessor in WebView
https://bugs.webkit.org/show_bug.cgi?id=89545

Attachment 148492: Patch
https://bugs.webkit.org/attachment.cgi?id=148492&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is OK, but a better patch would be to move the cookieEnabled setting
to the Settings object.  I did a quick look and this isn't used in many places,
so it should be easy to move.  Would you be willing to move it so we can put
the API in the right place (i.e., WebSettings)?


More information about the webkit-reviews mailing list