[webkit-reviews] review granted: [Bug 89158] test-webkitpy: add a -p flag to pass through captured output to enable debugging : [Attachment 148465] update w/ more review feedback

[bugzilla-daemon at webkit.org]

Eric Seidel (OOO until 6/19) <eric at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 89158: test-webkitpy: add a -p flag to pass through captured output to
enable debugging
https://bugs.webkit.org/show_bug.cgi?id=89158

Attachment 148465: update w/ more review feedback
https://bugs.webkit.org/attachment.cgi?id=148465&action=review

------- Additional Comments from Eric Seidel (OOO until 6/19) <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148465&action=review


Looks great.  I don't need to see this again, but you might find my nits below
helpful (or not). :)  Thanks again.

> Tools/Scripts/webkitpy/test/main.py:65
> +	   parser.add_option('-p', '--pass-through', action='store_true',
default=False,
> +			     help='enable the python debugger by passing
captured output through to the system')

"enable the python debugger" sounds like it's turning on the debugger.	Maybe
you want it do do that too?

> Tools/Scripts/webkitpy/test/main.py:199
> +class _CaptureAndPassThroughStream(object):

This name is no longer probably specific enough, now that I understand what
this code does. :)  It probably should mention the debugger or pdb.