[webkit-reviews] review denied: [Bug 89530] Web Inspector: Allow module injections into the InjectedScript : [Attachment 148460] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 89530: Web Inspector: Allow module injections into the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89530

Attachment 148460: Patch
https://bugs.webkit.org/attachment.cgi?id=148460&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148460&action=review


> Source/WebCore/inspector/InjectedModule.h:42
> +class InjectedModule : public InjectedScriptBase {

InjectedScriptModule

> Source/WebCore/inspector/InjectedModule.h:49
> +    friend void InjectedScript::injectModule(InjectedModule&, bool&);

friend class InjectedScript

> Source/WebCore/inspector/InjectedScript.cpp:242
> +    ASSERT(!hasNoValue());

I would try to hold all the module-related logic in a single location.
(InjectedScriptModule). Eventually, we might want to make generic injected
script a module itself.