[webkit-reviews] review denied: [Bug 89506] GraphicsContext::setCTM usage in SVGInlineTextBox::paintTextWithShadows breaks per-tile painting in chromium. : [Attachment 148431] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 16:39:41 PDT 2012


James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 89506: GraphicsContext::setCTM usage in
SVGInlineTextBox::paintTextWithShadows breaks per-tile painting in chromium.
https://bugs.webkit.org/show_bug.cgi?id=89506

Attachment 148431: Patch
https://bugs.webkit.org/attachment.cgi?id=148431&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
R- for now - this isn't an obvious improvement or even obviously correct (there
was some logic in normalizeTransform that is no longer called, although I'm not
sure what it is all about).

If all this wants to do is locally set a scale, could we just undo the scale by
hand instead of save()/restore()ing the whole context?


More information about the webkit-reviews mailing list