[webkit-reviews] review granted: [Bug 64489] NRWT spins up and down the WebSocket server when running a single HTTP test from the command line : [Attachment 148359] do not start http server unless necessary, either

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 15:56:00 PDT 2012


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 64489: NRWT spins up and down the WebSocket server when running a single
HTTP test from the command line
https://bugs.webkit.org/show_bug.cgi?id=64489

Attachment 148359: do not start http server unless necessary, either
https://bugs.webkit.org/attachment.cgi?id=148359&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
In manager.py, around line 763, we call start_servers_with_lock() if we have
locked_shareds.  Should we change that condition? E.g., if I run only perf
tests, we still acquire the http lock (although after this change, we will no
longer start up the http servers).


More information about the webkit-reviews mailing list