[webkit-reviews] review canceled: [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs : [Attachment 147678] Patch with a proposed fix for the bug (with layout tests, more recently synced, no extra files, better style)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 15:55:48 PDT 2012


Pete Williamson <petewil at chromium.org> has canceled Pete Williamson
<petewil at chromium.org>'s request for review:
Bug 88665: Favicon URL list sent with favicon updated message contains out of
date icon URLs
https://bugs.webkit.org/show_bug.cgi?id=88665

Attachment 147678: Patch with a proposed fix for the bug (with layout tests,
more recently synced, no extra files, better style)
https://bugs.webkit.org/attachment.cgi?id=147678&action=review

------- Additional Comments from Pete Williamson <petewil at chromium.org>
Addresses Kent's concern about not adding methods to the public interface of
WebDocument by using "Internals" instead.  Now instead of using a dump routine,
we have an internals routine that provides a list of the current Icon URLs
attached to the head of a document as a string, and the unit test checks that
string.


More information about the webkit-reviews mailing list