[webkit-reviews] review granted: [Bug 88924] [chromium] Add an allocation step for CCRenderer before drawing a frame : [Attachment 148402] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 14:17:16 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 88924: [chromium] Add an allocation step for CCRenderer before drawing a
frame
https://bugs.webkit.org/show_bug.cgi?id=88924

Attachment 148402: Patch
https://bugs.webkit.org/attachment.cgi?id=148402&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148402&action=review


R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCRenderer.h:71
> +    // This method should be a no-op in a nested compositor that does not
render its passes directly.

Not sure this comment adds anything.  Other functions will probably be a no-op
too.  We can document that in the derived interface.


More information about the webkit-reviews mailing list