[webkit-reviews] review granted: [Bug 88565] Add monitor profile support for Win and Mac : [Attachment 148355] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Payne <tpayne at chromium.org>'s
request for review:
Bug 88565: Add monitor profile support for Win and Mac
https://bugs.webkit.org/show_bug.cgi?id=88565

Attachment 148355: Patch
https://bugs.webkit.org/attachment.cgi?id=148355&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148355&action=review


> Source/Platform/chromium/public/Platform.h:181
> +    // Supplies the system monitor color profile.
> +    virtual void monitorColorProfile(const WebString&, WebVector<char>*) { }


Should we have a WebColorProfile type?	It could even just be a typedef for a
WebVector.

> Source/WebCore/platform/PlatformScreen.h:55
> +    void screenColorProfile(Widget*, const WTF::String&, ColorProfile*);

WTF::String -> String

Should we name the second parameter?  It's not clear to me what it represents. 
Also, the convention in WebKit is to pass out parameters by (non-const)
reference.