[webkit-reviews] review requested: [Bug 89470] webkitpy: Make webkit-patch patches-to-review useful : [Attachment 148387] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 12:13:01 PDT 2012


Thiago Marcos P. Santos <tmpsantos at gmail.com> has asked  for review:
Bug 89470: webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470

Attachment 148387: Patch v2
https://bugs.webkit.org/attachment.cgi?id=148387&action=review

------- Additional Comments from Thiago Marcos P. Santos <tmpsantos at gmail.com>
Thanks for reviewing. I moved all the printing logic to a separated method, so
as the the report generation logic. Replaced the short bug URL with the one
within WK domains. Also added the padding trick for the bug url column (not
exactly at the same line as it was suggest by the review). A new utest was
added to verify if the default username is the same as the bugzilla username.


More information about the webkit-reviews mailing list